If DebMaker.depends is set, then set it in the control file #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s set. When the change to no longer include the default depends was made in tcurdt#209 to fix tcurdt#208 it entirely eliminated the ability to set the depends programatically. In fact, the field DebMaker.depends is never read.
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
============================================
+ Coverage 66.83% 67.18% +0.34%
- Complexity 88 91 +3
============================================
Files 7 7
Lines 579 582 +3
Branches 76 78 +2
============================================
+ Hits 387 391 +4
+ Misses 142 140 -2
- Partials 50 51 +1
Continue to review full report at Codecov.
|
|
Thanks for the PR! Looks good. Similar to https://github.com/tcurdt/jdeb/blob/master/src/test/java/org/vafer/jdeb/DebMakerTestCase.java#L170 |
Also augment DebMakerTestCase#testDependsIsOmittedWhenEmpty to fail if control is missing entirely.
Thank you!
Sure! Just pushed a new commit with a unit test. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes DebMaker include the depends field in the control file if and only if the field was set.
When the change to no longer include the default depends was made in #209 to fix #208 it entirely eliminated the ability to set the depends programatically. In fact, the field DebMaker.depends is never read.
It does not appear that removing support for setting depends programmatically was intended by the conversations in #209 and #208.